Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Feb 25, 2025


PR-Codex overview

This PR updates the authentication method for fetching routes in the getRoutes function, replacing the DASHBOARD_THIRDWEB_CLIENT_ID with DASHBOARD_THIRDWEB_SECRET_KEY and introducing a call to getAuthToken() for bearer token authentication.

Detailed summary

  • Replaced DASHBOARD_THIRDWEB_CLIENT_ID with DASHBOARD_THIRDWEB_SECRET_KEY in the headers.
  • Added a call to getAuthToken() to retrieve the bearer token.
  • Adjusted the headers to use bearer token authentication if available, otherwise using the secret key.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 25, 2025 05:42
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: eef4af9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 6:20am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 25, 2025 6:20am
login ⬜️ Skipped (Inspect) Feb 25, 2025 6:20am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 25, 2025 6:20am
wallet-ui ⬜️ Skipped (Inspect) Feb 25, 2025 6:20am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.25 KB (0%) 925 ms (0%) 526 ms (+25.21% 🔺) 1.5 s
thirdweb (cjs) 121.91 KB (0%) 2.5 s (0%) 1.4 s (+40.38% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 53 ms (+5.65% 🔺) 165 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+131.79% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.31 KB (0%) 387 ms (0%) 252 ms (+329.08% 🔺) 638 ms

@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 06:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 06:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 06:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 06:08 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 06:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 06:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 06:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 06:09 Inactive
@gregfromstl gregfromstl merged commit cf202c0 into main Feb 25, 2025
28 of 30 checks passed
@gregfromstl gregfromstl deleted the greg/fix-routes-page-fetch branch February 25, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants